Move common submission arguments to the submission configuration

[jmg-duarte]

Description

Before we move the builder submission further, it's time we take care of some tech debt that we accrued over time by cleaning up the configuration file. To start, we move the max-additional-tip and additional-tip-percentage that we always set to the same values up to the common submission section.

Changes

• Move max-additional-tip and additional-tip-percentage to the common submission section

How to test

Existing tests shouldn't break, namely E2E ones

[claude]

Claude finished @jmg-duarte's task in 1m 15s —— View job

---

PR Review

Clean, well-scoped tech-debt cleanup — moving max-additional-tip / additional-tip-percentage from the per-mempool section up to the common [submission] section. The serde_as/default attributes moved correctly, load.rs sources both fields from config.submission, and the test + example.toml were updated consistently.

I left one inline comment flagging a silent config-migration hazard: Mempool lacks deny_unknown_fields, so stale per-mempool keys in deployment configs won't error — they'll be silently ignored and fall back to defaults (3 gwei / 0.05). Worth migrating deployment configs in lockstep.

Otherwise LGTM. The loss of per-mempool tip granularity is intentional per the PR description.

• Read PR diff
• Analyze config changes & usages
• Post inline comments for any issues
• Post summary
  · jmgd/submission-tip-params

[claude]

Heads-up on a silent config-migration hazard with this move: unlike SubmissionConfig, the Mempool struct does not have #[serde(deny_unknown_fields)]. So any deployment config that still carries max-additional-tip / additional-tip-percentage under [[submission.mempool]] after this change will not error — the keys are silently ignored, and the values fall back to the defaults (default_max_additional_tip = 3 gwei, default_additional_tip_percentage = 0.05).

Concretely: if a production config currently sets e.g. max-additional-tip = "5000000000" per-mempool and isn't migrated to [submission] in lockstep with this binary, the effective max tip silently drops from 5 gwei to 3 gwei. Worth ensuring all deployment configs are updated alongside this PR (and ideally calling it out in the release notes), since there's no compile- or load-time guard to catch a stale config.

[jmg-duarte]

Handled in https://github.com/cowprotocol/infrastructure/pull/7285

[MartinquaXD]

Good change but doesn't address the ugly configuration fully.

[claude]

Claude finished @jmg-duarte's task in 1m 28s —— View job

---

PR Review

Re-reviewed after the latest push (e7e4e6c9 Address Martin's comments). This is now a clean, well-scoped refactor.

Looks good:

• max_additional_tip / additional_tip_percentage moved to the common [submission] section with the serde_as/default attributes carried over correctly.
• The follow-up concern from Martin is fully addressed: adjustments() is gone, GasPriceParameters is now a dedicated #[derive(Clone)] config field built directly from config.submission in load.rs, and run.rs just clones it. This removes the per-mempool coupling that previously blocked cleaning up gas::adjustments().
• Dead code cleaned up consistently: mempool::Config loses min_priority_fee/gas_price_cap/max_additional_tip/additional_tip_percentage and the test_config helper; tests and example.toml updated in lockstep.
• No behavior change: gas_price_cap/min_priority_fee were already sourced from config.submission for every mempool, so the old min/max-across-mempools aggregation was a no-op; defaults (3 gwei / 0.05) are preserved.

Note (already acknowledged, not blocking): Mempool still lacks #[serde(deny_unknown_fields)], so a stale max-additional-tip/additional-tip-percentage under [[submission.mempool]] would be silently ignored rather than erroring. The author confirmed deployment configs are migrated in infrastructure#7285, so this is handled.

LGTM. ✅

---

• Read PR diff
• Analyze config changes & gas.rs cleanup
• Verify no stale references / unused imports
• Post summary
  · jmgd/submission-tip-params