[jmg-duarte]

Description

Following the reflow from v1/trades traffic to v2/trades in https://github.com/cowprotocol/infrastructure/pull/6821, this PR fully removes v1/trades, the v1/trades reflow should also be removed following this.

Changes

• Fully remove v1/trades endpoint

How to test

N/A

[github-actions]

Reminder: Please consider backward compatibility when modifying the API specification.
If breaking changes are unavoidable, ensure:

• You explicitly pointed out breaking changes.
• You communicate the changes to affected teams (at least Frontend team and SAFE team).
• You provide proper versioning and migration mechanisms.

---

Caused by:

• crates/orderbook/openapi.yml

[claude]

Claude finished @jmg-duarte's task in 52s —— View job

---

PR Review: Remove the v1 trades endpoint

• Read the diff and gather context
• Verify callers migrated to /api/v2/trades behave correctly
• Check for lingering references to the removed endpoint

Verdict: LGTM ✅ — clean, well-scoped removal. No changes requested.

I verified:

• The deleted handler (get_trades.rs) and its route registration in api.rs are the only server-side wiring removed; the OpenAPI entry is also dropped. ✅
• No lingering /api/v1/trades references remain anywhere (code, docs, playground, configs). ✅
• The two remaining callers now point at /api/v2/trades:
  • crates/e2e/src/setup/services.rs get_trades() helper
  • playground/test_playground.sh

One thing I considered (not blocking): v2 differs from v1 in that it is paginated with a default limit of 10, whereas v1 was unpaginated. This is safe here because every get_trades() caller queries by a single orderUid, which realistically yields 1–few trades — comfortably within the default page size. The response shape stays a JSON array, so .first() / [0] / jq '.[0]' usages are unaffected. No change needed, just noting it for the record.
· jmgd/remove-v1-trades

[MartinquaXD]

🧹