Repository navigation
Write scaffolded code for solana bitget solver #5106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AryanGodara
wants to merge
4
commits into
main
Choose a base branch
from
aryan/be-252-bitget-scaffold
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e6cbb3c
write stub code for solana bitget solver
AryanGodara 1bf5004
Merge remote-tracking branch 'origin/main' into aryan/be-252-bitget-s…
AryanGodara 7e4ddf5
minor comment fixes
AryanGodara da27e6f
Merge branch 'main' into aryan/be-252-bitget-scaffold
AryanGodara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Example Bitget solver configuration. | ||
| # Run with: solana-solvers bitget --config <this file> | ||
|
|
||
| # Orders quoted at once. Each quote is one Bitget request. | ||
| concurrent-requests = 8 | ||
| # Pause after a rate-limited response: min-back-off at first, multiplied by | ||
| # back-off-growth-factor per consecutive one, capped at max-back-off. | ||
| back-off-growth-factor = 2.0 | ||
| min-back-off = "1s" | ||
| max-back-off = "8s" | ||
|
|
||
| [dex] | ||
| # Bitget swap API base URL, or a proxy route to it. Keep the trailing slash. | ||
| endpoint = "https://bopenapi.bgwapi.io/bgw-pro/swapx/pro/" | ||
| # Credentials from the Bitget developer portal. Requests are signed with the secret. | ||
| api-key = "your-bitget-api-key" | ||
| api-secret = "your-bitget-api-secret" | ||
| # Slippage tolerance in basis points. 50 = 0.5%. | ||
| slippage-bps = 50 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| //! Bitget swap-API adapter. | ||
|
|
||
| use { | ||
| super::{Error, Order, Swap}, | ||
| solana_sdk::pubkey::Pubkey, | ||
| }; | ||
|
|
||
| pub struct Bitget; | ||
|
|
||
| impl Bitget { | ||
| // TODO(BE-253): quote the order and build the swap. | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is done in next PR |
||
| pub async fn swap(&self, _order: &Order, _taker: &Pubkey) -> Result<Swap, Error> { | ||
| Err(Error::NotFound) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking / for the next PR: correctness here relies entirely on a prose comment ("needs the trailing slash"). Because
Url::join("swap")replaces the last path segment when the base lacks a trailing slash, a deploy config of.../swapx/pro(no slash) would silently resolve to.../swapx/swaprather than.../swapx/pro/swap— a wrong endpoint with no error. Worth validating/normalizing the trailing slash in theBitgetconstructor when the swap adapter lands (BE-253), rather than trusting operators to read the comment.