Repository navigation
Release workos-authkit from CI with Changesets - #84
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
commit: |
There was a problem hiding this comment.
1 issue found across 12 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/test.yml">
<violation number="1" location=".github/workflows/test.yml:57">
P2: `pkg-pr-new` cannot authenticate this job with only `contents: read`, and the fallback reports success when publishing fails. Grant `id-token: write` and fail the step on publication errors.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| git diff --exit-code -- src/component/_generated example/convex/_generated | ||
| test -z "$(git ls-files --others --exclude-standard src/component/_generated example/convex/_generated)" | ||
| - name: Publish package for testing branch | ||
| run: npx pkg-pr-new publish || echo "pkg-pr-new failed" |
There was a problem hiding this comment.
P2: pkg-pr-new cannot authenticate this job with only contents: read, and the fallback reports success when publishing fails. Grant id-token: write and fail the step on publication errors.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/test.yml, line 57:
<comment>`pkg-pr-new` cannot authenticate this job with only `contents: read`, and the fallback reports success when publishing fails. Grant `id-token: write` and fail the step on publication errors.</comment>
<file context>
@@ -4,31 +4,54 @@ concurrency:
+ git diff --exit-code -- src/component/_generated example/convex/_generated
+ test -z "$(git ls-files --others --exclude-standard src/component/_generated example/convex/_generated)"
+ - name: Publish package for testing branch
+ run: npx pkg-pr-new publish || echo "pkg-pr-new failed"
</file context>
There was a problem hiding this comment.
It's fine for this to fail. and I don't think it needs that permission. if we see issues we can fix forward
Adopts the shared staged npm publishing and Changesets workflows.
checkstays offline and fast; CI initializes a local anonymous deployment and sets placeholder WorkOS values before the separate E2E/codegen gate, withoutCONVEX_AGENT_MODEor real credentials. Adds.convex/to Prettier and Git ignores. Local build, check, anonymous E2E, generated-code comparison, and workflow lint passed. No package version bump or publication is included.