Repository navigation
Preserve ConvexError data across workflow steps and replay - #316
Open
ianmacartney wants to merge 4 commits into
Open
ianmacartney wants to merge 4 commits into
ianmacartney wants to merge 4 commits into
Conversation
commit: |
ianmacartney
marked this pull request as ready for review
November 11, 2026 03:16
There was a problem hiding this comment.
All reported issues were addressed across 14 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
ConvexErrorthrown by a workflow step currently reaches the workflow as a plainError, losing its structured.data. Preserve that data for inline steps and workflow-handler failures, and reconstructConvexErrorwhen resolving failed steps from the journal. Queued functions and nested workflows carry the same payload through completion callbacks. Historical failures without structured data remain ordinary errors.Measure the complete serialized failure, including its message/stack and error data, against the existing 800 KiB result budget. Oversized failures become a bounded diagnostic without structured data. Apply the guard before inline/handler failures cross into the component, and when the component processes completion results, so failed steps can be journaled and caught through replay.
Fixes #315. Uses released
@convex-dev/workpool0.4.16, including convex/workpool#257. The peer minimum is^0.4.16; the changeset requests a minor release for this increased requirement.Validation: