Repository navigation
Fix VDatum reference issues and add common datum names (#190) - #191
Merged
Merged
Conversation
* Add vdatum:mtl and vdatum:dtl references and operation bindings * Extract VDatum model grids into cache_dir instead of the working directory * Derive InvalidReferenceError and UnsupportedReferenceError from ReferenceInputError (a ValueError) rather than the built-in ReferenceError * Accept common vertical datum names (navd88, egm2008, egm96, prvd02, vivd09, asvd02, cgvd2013, spelled-out tidal datums) in parse_reference() * Update changelog Closes #190
matth-love
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the VDatum reference issues from #190.
vdatum:mtlandvdatum:dtlreferences and operation bindingscache_dirinstead of the current working directoryInvalidReferenceErrorandUnsupportedReferenceErrornow derive fromReferenceInputError(aValueError) instead of the built-inReferenceErrorparse_reference()accepts common vertical datum names (navd88,egm2008,egm96,prvd02,vivd09,asvd02,cgvd2013, and spelled-out tidal datums such asmean lower low water). Names PROJ already resolves are left to PROJ, so existing inputs parse the same way.Item 4 (the
epsg:5714label) is intentionally left unchanged, per the discussion on the issue.Tested by transforming a synthetic raster over Chesapeake Bay from
vdatum:mtlandvdatum:dtlto NAVD88, MLLW and MSL. The shifts match the raw VDatum grids, and a direct MTL→MLLW transform matches the MTL→NAVD88→MLLW route exactly.Closes #190
🔍 Docs preview: https://transformez--191.org.readthedocs.build/en/191/