Repository navigation
Let globato.read() take ignore_failures - #274
Merged
Merged
Conversation
matth-love
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
ignore_failuresparameter toglobato.read(), passed throughGlobatoStreamto fetchez'sBaseStream.read()had no way to set it: its**kwargsgo to the modules, andGlobatoStreamdidn't pass it on.With fetchez #472, an error a reader raises while the stream is read, such as
AuxiliaryDataError, is raised to the code iterating the stream whenignore_failuresis off, the default.read(ignore_failures=True)keeps the earlier behavior: the error is logged and the stream ends early.The new test covers
read(ignore_failures=True)on a file its reader can't open, which ends the stream without raising. It passes with any fetchez release, since CI installs fetchez from PyPI.