fix(contentstack): include tslib as runtime dependency - #2721
Open
goodguypeci-design wants to merge 1 commit into
Open
fix(contentstack): include tslib as runtime dependency#2721goodguypeci-design wants to merge 1 commit into
goodguypeci-design wants to merge 1 commit into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change directly addresses the reported runtime MODULE_NOT_FOUND by correctly promoting tslib to a production dependency, with the lockfile updated to match.
Pull request overview
This PR fixes a runtime install failure for the published @contentstack/cli package by ensuring tslib is installed for consumers. Since packages/contentstack/tsconfig.json has importHelpers: true, the compiled output can require tslib at runtime, so it must be a production dependency.
Changes:
- Moved
tslibfromdevDependenciestodependenciesinpackages/contentstack/package.json. - Updated
pnpm-lock.yamlimporter entry accordingly so the lockfile reflects the runtime dependency.
File summaries
| File | Description |
|---|---|
packages/contentstack/package.json |
Adds tslib to runtime dependencies and removes it from devDependencies for @contentstack/cli. |
pnpm-lock.yaml |
Updates the packages/contentstack importer dependency graph to match the package.json change. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
/claim #2629 |
goodguypeci-design
force-pushed
the
fix-tslib-runtime-dependency
branch
from
September 8, 2026 14:06
00e1e48 to
db1ef32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers can install
@contentstack/cliwithout its development packages and then hitCannot find module 'tslib'. The package compiles withimportHelpers: true, so some generated JavaScript imports helpers fromtslibat runtime even though it was only listed as a development dependency.This moves
tslibinto the package's runtime dependencies and updates the matching pnpm lockfile entry. I regenerated the lockfile without running install scripts, built every workspace package, and packed@contentstack/clito confirm that the published package metadata now includesdependencies.tsliband no longer lists it underdevDependencies.Fixes #2629.