Skip to content

Qm 1.1.z - #991

Merged
dougsland merged 3 commits into
containers:qm-1.1.zfrom
dougsland:qm-1.1.z
Sep 17, 2026
Merged

dougsland merged 3 commits into
containers:qm-1.1.zfrom
dougsland:qm-1.1.z

Conversation

@dougsland

@dougsland dougsland commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Summary by Sourcery

Prepare the 1.1.z release with the renamed qmctl RPM package and backward-compatible packaging metadata.

Enhancements:

  • Rename the RPM controller subpackage to qmctl while preserving compatibility with the previous package name and ensuring versioned dependencies include the package epoch.

Build:

  • Update the package specification for the renamed qmctl RPM subpackage.

Chores:

  • Bump the project version and SELinux policy version metadata.

dougsland and others added 3 commits September 17, 2026 11:53
The tool is named qmctl, so update the spec file to match the tool's name.

Signed-off-by: Douglas Landgraf <dlandgra@redhat.com>
(cherry picked from commit 600c6de)
Include epoch in qmctl Provides and Obsoletes to ensure
proper upgrades from qm-ctl in COPR builds.

Signed-off-by: Douglas Landgraf <dlandgra@redhat.com>
(cherry picked from commit f6c7e5b)
Signed-off-by: Douglas Landgraf <dlandgra@redhat.com>
@sourcery-ai

sourcery-ai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This release updates version metadata and restructures the RPM controller component as a standalone qmctl package, with epoch-aware dependency and compatibility metadata to support clean upgrades from the former qm-ctl package.

File-Level Changes

Change Details Files
Renames the controller subpackage to the standalone qmctl package while preserving upgrade and dependency compatibility.
  • Changes RPM metadata from the implicit ctl subpackage to an explicitly named qmctl package.
  • Adds epoch-aware dependency, Provides, and Obsoletes version expressions for package transitions.
  • Updates package description and file ownership declarations to target qmctl.
rpm/qm.spec
Updates the project and SELinux policy version metadata for the Qm 1.1.z release.
  • Bumps the recorded project version.
  • Aligns the SELinux policy module version with the release.
VERSION
qm.te

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. The package rename changes installed package identity and upgrade/obsoletion behavior, so a bad spec could leave the controller package missing or create dependency and upgrade problems that persist after reverting the source. Those package states are bounded and repairable by correcting the package metadata and reinstalling or rerunning the upgrade.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@dougsland

Copy link
Copy Markdown
Member Author

There are issues already opened to address these ci/cd errors. Not to related to the patch.
We also need to deprecate the centos-stream-9.
#986

@dougsland
dougsland merged commit a00f4b4 into containers:qm-1.1.z Sep 17, 2026
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant