feat(agentic-server): describe single-provider options as a convenience, not legacy - #1869
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No issues found — approved ✅. This PR touches only comment content in the agentic server providers and types files, with no changes to executable logic. Reviewed commit: e981c82 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a comment-only change that carries out the agentic env-var decision on constructive-io/constructive-planning#2152. The single-provider options (
providerType,providerBaseUrl,providerApiKey,defaultModel) stay as the one-provider dev convenience, but they are no longer labelled "Legacy". Behaviour does not change.Layer
agentic/agentic-serveroptions docs.resolveProvider.Link to Devin session: https://app.devin.ai/sessions/0f9216183d904190b25c5344962e2f12
Open in Devin Desktop: https://app.devin.ai/desktop/session/0f9216183d904190b25c5344962e2f12?variant=devin
Requested by: @pyramation