style: flat docs borders, framed home hero, and button-group edge fixes - #40
Merged
Merged
Conversation
…divider over the fill The group applied rounded-r-none to every child, so the last button lost its outer corners; the selectors now square :not(:last-child) trailing and :not(:first-child) leading edges (Button's before: overlay included), which holds for any child count. The separator had its width zeroed by an override on the wrong axis and sat in a slot that exposed the page; it is now a 1px translucent ink line pulled over the preceding edge, so it tints whatever it divides. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…ome hero The home hero becomes a square, flat panel inset by the page gutter so its edges line up with the showcase grid; every docs surface that relied on the faint shadow hairline (example frames and their bars, catalog and page tiles, code blocks, the API table, install toggle, preset tiles, preview canvas) now uses an explicit --border, and tile hovers tint instead of lifting. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Review complete. No issues found — approved ✅. The change spans the docs app pages and shared docs components, plus a new UI component. It tightens borders and gutters across the registry chrome, reshapes page metadata (openGraph/OG_IMAGE), and refactors CodeBlock, api-table, catalog-card, install-toggle, primitive-preview, and theme-preset-grid. A new ButtonGroup component with corner-squaring edge selectors and separator ink lines was added along with a regression test.
All candidate findings fell below the confidence threshold; only low-confidence, unverified reachability notes were surfaced and none met the bar for an inline comment. Reviewed commit: bf376fc |
…d framed preview The dial stack loses its Actions folder; Randomize (a usable roll across theme presets and verified preset combinations that never repeats the current look), Reset, and Copy share link sit as an attached icon group beside Get code, all driving the shared draft so tiles, selects, dials and the preview stay in sync. The wall switcher is a ButtonGroup on an opaque surface. The wide-column 2×2 grids that aligned rows to their tallest card become independent stacks and the measured column heights are rebalanced, so no voids remain and column bottoms end within a card of each other. The preview pane and the panel get the flat 1px border used across the docs. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visual fine-tuning on top of the redesign.
--border, no shadow, overlays clipped to the frame.--border: example frames and their bars, catalog and page tiles (AI / billing / features / command palette), code blocks, API table, install toggle, preset tiles, preview canvas. Tile hovers tint instead of lifting.rounded-r-noneapplied to every child; selectors now square only the shared edges (:not(:first-child)/:not(:last-child), Buttonbefore:overlay included), which holds for any child count.ButtonGroupSeparatorhad its width zeroed by an override on the wrong axis and sat in a slot that showed the page through; it is now a 1px translucent ink line drawn over the preceding edge, so it tints whatever fill it divides. Unit test pins the selectors.Visual
Generated with Devin