Skip to content

upgrade go to version 1.26.7 - #3541

Open
Acepresso wants to merge 2 commits into
conforma:release-v0.6from
Acepresso:v0.6-upgrade-go
Open

upgrade go to version 1.26.7#3541
Acepresso wants to merge 2 commits into
conforma:release-v0.6from
Acepresso:v0.6-upgrade-go

Conversation

@Acepresso

Copy link
Copy Markdown
Contributor

Also updated 3 packages in package-lock.json following npm complain.

- node_modules/lodash 4.17.21 -> 4.18.1
- node_modules/picomatch 2.3.1 -> 2.3.2
- node_modules/yaml 1.10.2 -> 1.10.3
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 9a0bf9de-1a41-4eb9-87ad-017ef1c5d3ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 3, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:00 PM UTC · Completed 2:10 PM UTC

Commit: ca5794c · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.12

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
generative 70.92% <ø> (ø)
integration 70.92% <ø> (ø)
unit 70.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Sep 3, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Small Go version bump (8 files, 32 lines) with protected path changes (Dockerfiles) and multiple dependency files, offset by low git history churn and a non-first-time human author.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

High

  • [protected-path] Dockerfile, Dockerfile.dist — PR modifies protected infrastructure files (Dockerfiles) without a linked issue providing authorization context. Human approval is always required for changes to governance and infrastructure files. Remediation: link this PR to an issue that authorizes changes to the Dockerfile protected path, or obtain explicit human approval from a reviewer with governance access.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

@simonbaird

Copy link
Copy Markdown
Member

PR is fine, but the release-v0.6 branch is no no longer maintained. Notice there's no Konflux build for this PR. Probably best to abandon rather than merge, since it might be confusing if there is an update the old branch.

@simonbaird simonbaird left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be abandoned, do you agree?

@simonbaird

Copy link
Copy Markdown
Member

Also I think this would produce a bunch of Conforma violations, but we don't see them because there are no Konflux builds triggered here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/moderate PR risk: moderate size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants