Close old database connections around task execution - #43
Merged
Conversation
Register a receiver for the task_started and task_finished signals that calls close_old_connections(), so worker processes reuse database connections the same way request handlers do, honoring CONN_MAX_AGE. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long-running worker processes otherwise hold on to database connections for the life of the process, so stale or broken connections get reused across tasks. This gives tasks the same connection lifecycle Django gives request handlers: connections are dropped via
close_old_connections()when a task starts and when it finishes, honoringCONN_MAX_AGE.