Show module path when logging tasks - #42
Merged
Merged
Conversation
codingjoe
reviewed
Sep 2, 2026
codingjoe
left a comment
Owner
There was a problem hiding this comment.
Howdy, fancy seeing you here :)
Good idea. I honestly wish the TaskResult had a better __repr__ method. That would make logging simpler.
How about we slightly invert the order:
Task "foo.bar.baz" with result "asdf-asdf-asdf" succeeded.
or
Task "asdf-asfd-asfd@foo.bar.baz" succeeded.
In addition to logging the ID, the module_path can also be useful while debugging to know what is being run at a glance.
Contributor
Author
|
|
codingjoe
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to logging the ID, the module_path can also be useful while debugging to know what is being run at a glance.
I figured the code example was faster to write and easier to understand than opening a regular issue to ask first, so let me know if this looks ok, or if you would like me to change the format a bit.