Repository navigation
feat: cover letters in the candidate's own style and structure - #63
Merged
Merged
Conversation
The letter now follows the candidate's Jump Trading letter, measured from the PDF:
a Gelasio name with the surname in sage, a sage rule, a right-aligned left column
(contact without the street address, then "Recruitment Team, / Company, / Town.")
beside the letter, a sage line between them and a sage band on the page's foot.
No date or "Re:" line; "Dear Hiring Manager" as a heading; "Kind Regards,".
The generator writes the same four parts: a hook from the hardest challenge in one
of the candidate's projects tied to a concrete fact about the employer, two projects
as evidence ("Separately, ..."), an honest gap taken from a real requirement in the
ad, and the candidate's closing line, which is now enforced along with the sign-off.
The critique rubric judges against that structure. "C++" no longer breaks across
lines, and the editor drops the Date and Re: fields the letter no longer shows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cover letters should look and read like the user's own Jump Trading letter. The old letter was a plain full-width page with a date, an address block, a "Re:" line and "Yours faithfully". Its body followed a generic intro / why them / why me / ending formula.
What changed
Layout (
classic_letter.html, newletter.css, measured from the user's PDF)position: fixedin print, because WeasyPrint places an absolute box under a min-height body right after the text.base.css.Writing (
agent.generate_cover_letter)_LETTER_RUBRICjudges against that structure.Smaller
Tests
tests/test_documents.py:After deploy
Rebuild with
docker compose up -d --build api frontend. Autopilot writes new documents on every run, so the next letters use this style.