Conversation
GraphNode carried only line/column, so spanOf() in schema/v2/dataflow.ts hardcoded bytes:[0,0] for every L3 entry/exit/param/statement node — module.source.slice(...) on any L3 body node returned "". Add start_offset/end_offset (UTF-16 char offsets, matching the L1 convention) to GraphNode, populate them at the single construction site (dataflow/extract.ts's emitNode, from the owning ts-morph node's getStart()/getEnd() — the whole callable for entry/exit, the param decl for param nodes), and have spanOf() use them.
7 tasks
rahlk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28. Part of epic #26 (contract-correctness cluster).
Stacked PR 2 of 7 — base:
test/issue-27-monotonicity-gate; review this PR's diff in isolation. Merge the stack bottom-up intofeat/issue-2-program-graphs.Verified: full suite 99 pass / 0 fail, typecheck clean, schema.neo4j.json in lockstep. Reviewed (task-scoped + final whole-branch review: READY TO MERGE).