Conversation
A module's can:// id gains a segment naming the module as it declares itself, so pointing --input at one service repo names that service in the id without staging directories and without pointing --input at a parent that sweeps in siblings. The symbol_table key keeps the real --input-relative path. Uniqueness is the key's job and a path is unique by construction where an artifactId is not; the module object carries no path field, so the key is also the only thing that locates a file on disk. The same non-uniqueness reaches the id, which is the join key for call_graph endpoints, so the prefix applies only when exactly one manifest directory claims it. A prefix claimed by two directories is applied to neither, with a warning naming the competitors — otherwise the change would regress "ids are distinct by construction", the property it was chosen for. Supersedes the won't-fix on #39, which declared the grammar settled in August. #36 regains a prerequisite as a result.
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec for adding a module-identity segment to
can://module ids, so pointing--inputat one service repo names that service in the id:Three decisions worth reviewer attention:
The
symbol_tablekey does not change (§4). Uniqueness is the key's job, and a path is unique by construction where anartifactIdis not — five services vendoring one internal library plausibly build it under the same module name, which would collapse five modules onto one key. The module object also carries no path field, so the key is the only thing locating a file on disk.The same non-uniqueness reaches the id (§6), which is the join key for
call_graphendpoints. So the prefix applies only when exactly one manifest directory claims it; a contested prefix is applied to neither, with a warning. Without that rule the change would regress "ids are distinct by construction" — the property it was chosen for.It supersedes the won't-fix on #39 (§10), which declared the
can://grammar settled in August. Re-opened deliberately, and recorded as such. #36 regains a prerequisite as a consequence and should be sequenced after this.Also documents what the change does not fix: codellm-devkit/codeanalyzer-java#269, where a single analysis spanning source roots that declare the same FQN binds every caller to the last root, silently. This makes a bundled tree addressable, not correctly resolved.