Skip to content

fix: --ask-again closes a lost open question, and the listener reports a bad outbox file - #35

Merged
groupsky merged 1 commit into
mainfrom
fix/ask-again-open-question
Nov 17, 2026
Merged

groupsky merged 1 commit into
mainfrom
fix/ask-again-open-question

Conversation

@groupsky

Copy link
Copy Markdown
Contributor

Fixes #22

What changes

  • pullgate status NAME --ask-again also removes an open question for the last tip from root's state. After the save, it asks the listener to close the message. The next run asks again with a new question ID and a new code. An approval for the old code finds no question and does nothing, also one that was written before --ask-again (fail closed).
  • The listener sends one notice per round when it removes an outbox file that it cannot read or parse: "an outbox message of instance NAME could not be read and was removed … run as root: pullgate status NAME --ask-again". It shows no part of the file. If the file cannot be removed, it sends no notice, so the chat does not get one notice per round.
  • DESIGN.md (sections 7, 8, 13), THREAT-MODEL.md (T9), README and the status help say what --ask-again does with an open question.

Tests

  • TestAskAgainReplacesALostQuestion: open question, --ask-again, the next run asks a new question with a new ID and code; an Apply for the old code applies nothing; the new one applies.
  • TestAskAgainDropsAnApprovalWrittenBefore: an approval for the old code that is already in the inbox applies nothing.
  • TestAskAgainInAutoMode: the auto question is removed with no edit; the old auto approval applies nothing; the next run queues a new one.
  • TestAskAgainKeepsAnOpenQuestionForAnotherSHA: only the question for the tip is touched.
  • TestBadOutboxFileTellsTheOwner: an unreadable file and a broken file are removed, one notice names the instance and the command, and holds no file content.
  • TestBadOutboxEntryThatStaysSendsNoNotice: an entry that cannot be removed gets no notice.

Reviews

Security review: no critical, high or medium findings. Two low findings, both fixed: no notice when the file was not removed, and tests for auto mode and for an approval written before --ask-again. Correctness review: no findings.

🤖 Generated with Claude Code

…s a bad outbox file

`pullgate status NAME --ask-again` now also removes an open question for
the last tip from root's state, then asks the listener to close its
message. The next run asks again with a new question ID and code. An
approval for the old code finds no question and does nothing.

The listener sends one notice per round when it removes an outbox file
that it cannot read or parse. It names the instance and the command
`pullgate status NAME --ask-again`, and shows no part of the file. When
the file cannot be removed, it sends no notice.

Fixes #22

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@groupsky
groupsky merged commit 38ecde6 into main Nov 17, 2026
9 checks passed
@groupsky
groupsky deleted the fix/ask-again-open-question branch November 17, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: --ask-again does not re-ask while the lost question is still open

1 participant