Repository navigation
fix: pullgate-listen.service gets an [Install] section - #24
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
groupsky
marked this pull request as ready for review
November 16, 2026 12:47
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
What was wrong
pullgate-listen.servicehad no[Install]section.systemctl enableprinted "The unit files have no installation config" and did nothing, so the listener did not start after a reboot.The fix
contrib/systemd/pullgate-listen.service:[Install]withWantedBy=multi-user.target.systemctl daemon-reloadandsystemctl reenable pullgate-listen.service. The issue proposedsystemctl remove-wants, but systemd has no such command (systemd 255 has onlyadd-wants). Theadd-wantsworkaround made the same link inmulti-user.target.wants/thatenablemakes now, andreenableremoves it and makes it again. It also says to keep your own unit changes in drop-ins, because the update copies the unit files again.Tests
test/units/install-sections.sh(CI job "example units", no root): reads everysystemctl enableline of the README (also withsudo, options, or a\line break) and checks that each unit has an[Install]section withWantedBy=. It fails if it finds fewer than 4 units. The job already runssystemd-analyze verifyon every unit incontrib/systemd/.test/units/first-run.sh(CI job "first run under the units", root on the throwaway runner), new at the end:[Install]) withadd-wants, then the new unit,daemon-reload,reenable. The link must exist andis-enabledmust sayenabled.systemctl enableon the four units of the README. Each must then beenabled, notstatic.FAIL: contrib/systemd/pullgate-listen.service has no [Install] section with WantedBy=, andFAIL: pullgate-listen.service: systemctl is-enabled says 'static' after enable, want 'enabled'.DESIGN.md section 14 describes the new checks. THREAT-MODEL.md does not change: no check, message, user or file location changes.
Reviews
The security reviewer and a correctness review ran on the diff. Fixed: the update test now uses the real old unit and checks
is-enabled; the README covers 0.1.0 hosts with no workaround too; the README parsing is wider and has a minimum count; the DESIGN text and the CI comment are exact; a sentence about drop-ins. Not changed: theawkcheck refusesWantedBy = xwith spaces; this can only fail, never pass wrongly, and no unit uses that form.🤖 Generated with Claude Code