Repository navigation
fix(repositories): download runtimes of unknown Popili versions unverified - #227
Draft
GPLeemrijse wants to merge 1 commit into
Draft
GPLeemrijse wants to merge 1 commit into
GPLeemrijse wants to merge 1 commit into
Conversation
GPLeemrijse
added this pull request to stack #232
October 16, 2026 14:23
GPLeemrijse
force-pushed
the
fix/unknown-version-runtime-sha
branch
from
October 16, 2026 14:39
3c54ccb to
c88692f
Compare
GPLeemrijse
force-pushed
the
fix/unknown-version-runtime-sha
branch
from
October 16, 2026 15:01
c88692f to
4f8b609
Compare
…ified The C and C++ runtime repositories passed `sha256 = None` for a version with no known_shas.bzl entry, which download_and_extract rejects, so a Popili release newer than the installed rules_coco could not be registered. They now pass "" like the popili archive download does and fetch unverified. Adds the e2e/forward_compat scenario, whose stage.py copies rules_coco with the newest registered version stripped from known_shas.bzl, and a hub unit test for a made-up version.
GPLeemrijse
force-pushed
the
fix/unknown-version-runtime-sha
branch
from
October 16, 2026 15:05
4f8b609 to
dadb500
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C and C++ runtime repositories passed
sha256 = Nonefor a version with noknown_shas.bzlentry, whichdownload_and_extractrejects, so a Popili release newer than the installed rules_coco could not be registered. They now pass""like the popili archive download does and fetch unverified.Adds the
e2e/forward_compatscenario, whosestage.pycopies rules_coco with the newest registered version stripped fromknown_shas.bzl, and a hub unit test for a made-up version.