Renovate: Update module sigs.k8s.io/structured-merge-diff/v6 to v7 - #358
renovate[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The v7 parser types are incompatible with Kubernetes managedfields APIs still typed against v6, so the project no longer compiles.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates sigs.k8s.io/structured-merge-diff from v6.4.2 to v7.0.0 and switches the generated parser import.
Changes:
- Adds the v7 module and checksums.
- Retains v6 transitively.
- Updates generated apply-configuration parsing.
Critical finding: the v7 parser is incompatible with Kubernetes APIs still typed against v6, causing compilation failure.
File summaries
| File | Reviewed changes |
|---|---|
go.sum |
Adds v7 dependency checksums. |
go.mod |
Adds v7 while retaining v6 indirectly. |
applyconfigurations/internal/internal.go |
Switches to the v7 typed parser, causing the identified incompatibility. |
Review details
Files not reviewed (1)
- applyconfigurations/internal/internal.go: Generated file
- Files reviewed: 1/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| sync "sync" | ||
|
|
||
| typed "sigs.k8s.io/structured-merge-diff/v6/typed" | ||
| typed "sigs.k8s.io/structured-merge-diff/v7/typed" |
5272e2e to
ea54208
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The generated parser change causes type incompatibilities with the current managedfields API and will fail to compile.
Review details
Files not reviewed (1)
- applyconfigurations/internal/internal.go: Generated file
Suppressed comments (1)
applyconfigurations/internal/internal.go:9
- This generated package now exposes
*structured-merge-diff/v7/typed.Parser, but thek8s.io/apimachinery v0.37.0managedfieldsAPI is built against the v6 typed package (the retained v6 indirect requirement is evidence of that dependency). As a result, calls such asmanagedfields.NewSchemeTypeConverter(scheme, internal.Parser())andmanagedfields.ExtractInto(..., internal.Parser().Type(...), ...)will fail to compile because the v7 types are not assignable to the v6 types. Keep the generated code on v6, or upgrade the Kubernetes dependency set to a release whose managedfields API uses v7 before switching this import.
- Files reviewed: 1/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
ea54208 to
bf5d3f3
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The v7 parser is incompatible with Kubernetes managed-fields APIs still using v6 types and will fail to compile.
Review details
Files not reviewed (1)
- applyconfigurations/internal/internal.go: Generated file
Suppressed comments (1)
applyconfigurations/internal/internal.go:9
- This changes the generated parser to
structured-merge-diff/v7, but the Kubernetesk8s.io/apimachineryv0.37.0 managed-fields APIs used by this package still consume the v6 typed-parser types (the v6 module remains ingo.modas an indirect dependency). Consequently, the calls inapplyconfigurations/utils.go:57and the generatedExtract*Fromfunctions cannot pass this parser and the package will fail to compile with an incompatible*typed.Parsertype. Keep this generated code on v6 until the Kubernetes dependency set is upgraded to the v7 API, or upgrade that whole dependency set together.
- Files reviewed: 1/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This PR contains the following updates:
v6.4.2→v7.0.0Release Notes
kubernetes-sigs/structured-merge-diff (sigs.k8s.io/structured-merge-diff/v6)
v7.0.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.