feat: add Buildkite OIDC credential detection - #415
Draft
cloudsmith-iduffy wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUILDKITEandBUILDKITE_JOB_IDbuildkite-agent oidc request-token--oidc-audience/CLOUDSMITH_OIDC_AUDIENCEoverride, defaulting tocloudsmithbuildkitedetectorTesting
uv run pytest -q cloudsmith_cli/core/tests/test_buildkite_detector.py cloudsmith_cli/core/tests/test_detector_controls.pyenv -u CLOUDSMITH_WORKSPACE -u CLOUDSMITH_ORG uv run pytest -q -m 'not integration'uv run pre-commit run --files cloudsmith_cli/core/credentials/oidc/detectors/buildkite.py cloudsmith_cli/core/credentials/oidc/detectors/__init__.py cloudsmith_cli/core/tests/test_buildkite_detector.py README.mdEnd-to-end validation
The detector was validated end to end with the reproducible
cloudsmith-iduffy/cloudsmith-cli-oidc-testharness. Its Buildkite pipeline configuration downloads the Linux x86_64 GNU standalone binary built from this PR's commitff2c7ceabcb6126643fc6c0e1b92b620eee0be1b, verifies its pinned SHA256, rejectsCLOUDSMITH_API_KEY, and runscloudsmith --debug whoami --verbosewith an isolated home directory.whoamioutput: Cloudsmith OIDC smoke-test jobNo Cloudsmith API key was supplied or available to the job; authentication used the Buildkite-issued OIDC token with audience
cloudsmith.