chore(ci): upgrade to pnpm 12.4.2 with corepack and enhance PR preview workflow - #1979
Conversation
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
|
There was a problem hiding this comment.
🟡 Changes recommended
The Docker compatibility workflow does not trigger for lockfile-only changes, allowing relevant Docker install inputs to bypass validation.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the repository and CI workflows to use pnpm 12.4.2 while adding Docker compatibility testing for existing pnpm 11 Dockerfiles.
Changes:
- Updates pnpm package-manager metadata and lockfile.
- Migrates CI and deployment workflows to pnpm 12.4.2.
- Adds multi-architecture Docker build validation.
File summaries
| File | Description |
|---|---|
pnpm-lock.yaml |
Locks pnpm 12.4.2 metadata and packages. |
package.json |
Updates the repository package manager. |
.github/workflows/test-docker-pnpm-12-upgrade.yaml |
Adds Docker compatibility tests. |
.github/workflows/release.yaml |
Uses pnpm 12 for releases. |
.github/workflows/deploy-pr-preview.yaml |
Uses pnpm 12 for previews. |
.github/workflows/deploy-github-pages.yaml |
Uses pnpm 12 for Pages deployment. |
.github/workflows/ci-checks.yaml |
Uses pnpm 12 for CI jobs. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 6/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
|
Summary
This PR upgrades the monorepo to pnpm 12.4.2, eliminates hardcoded pnpm versions across all workflows and Dockerfiles using corepack, and adds label-based triggering for PR previews. This fixes QEMU segfault issues on arm64 Docker builds and establishes package.json as the single source of truth for pnpm version management.
Changes Made
Monorepo
CI Workflows
package_json_file: package.jsoninstead of hardcoded versions:.github/workflows/ci-checks.yaml.github/workflows/deploy-github-pages.yaml.github/workflows/deploy-pr-preview.yaml.github/workflows/release.yamlDockerfiles
npm i -g pnpm@X.X.Xwithcorepack enable && corepack install:apps/supernova/docker/Dockerfileapps/greenhouse/docker/Dockerfiledocker/Dockerfile.devPR Preview Workflow Enhancement
ui-pr-previewlabel support for manual preview triggeringui-pr-previewlabel to any PR to force-build both Storybook and Example appcheck-preview-labeljob for single source of truthHow the label trigger works:
pull_requesttrigger withlabeledevent type (notpull_request_target)pathsfilter doesn't apply tolabeledevents, so the label works on any PRui-pr-previewlabel to trigger the workflowWhy pnpm 12.4.2?
pnpm 12.0.0+ introduced a hardlink-first strategy that triggered QEMU segfaults on arm64 emulated builds. pnpm 12.4.1+ includes hardlink fallback fixes:
Source: https://github.com/pnpm/pnpm/releases/tag/v12.4.1
Related Issues
Screenshots (if applicable)
N/A - Infrastructure changes only
Testing Instructions
pnpm installpnpm buildpnpm testChecklist
PR Manifesto
Review the PR Manifesto for best practises.