Repository navigation
#156 - Trigger a deprecation at runtime in LogRecord::contextIsEmpty() with trigger_deprecation() - #157
Merged
Conversation
…) with trigger_deprecation()
LogRecord::contextIsEmpty() was only deprecated in its PHPDoc (since v3.1, use hasContextInfo()): it now
triggers trigger_deprecation('cleverage/ui-process-bundle', '3.1', ...). Require
symfony/deprecation-contracts. Same convention as cleverage/process-bundle#273.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #156:
LogRecord::contextIsEmpty()(deprecated since v3.1 by #84, usehasContextInfo()) was only deprecated in its PHPDoc. It now triggers a deprecation at runtime:Same convention as cleverage/process-bundle#273 (PR cleverage/process-bundle#286) and the Symfony packages.
Changes
symfony/deprecation-contracts^2.5 || ^3(already installed through the Symfony components).LogRecord::contextIsEmpty():trigger_deprecation('cleverage/ui-process-bundle', '3.1', ...), behaviour unchanged.contextIsEmpty(): the UI pages do not trigger the deprecation.Tests
composer update: 397 tests OK, PHPStan, PHP-CS-Fixer, Rector OK.Requirements
Breaking changes
None: same behaviour, one more
E_USER_DEPRECATEDnotice when the deprecated method is called.🤖 Generated with Claude Code