Repository navigation
#149 - Clean up composer.json dependencies - #153
Merged
Merged
Conversation
- Remove the unused symfony/dotenv, symfony/runtime, ext-ctype and ext-iconv requirements (application concerns / Symfony skeleton leftovers). - Replace doctrine/common by doctrine/collections (only ArrayCollection is used). - Require twig/twig, symfony/twig-bundle, psr/log, doctrine/persistence, doctrine/migrations and symfony/event-dispatcher-contracts, used directly but only installed transitively; lower bounds are the ones already imposed by their current providers. - require-dev: twig/extra-bundle and symfony/property-access, used by the tests. symfony/runtime is kept in config.allow-plugins: cleverage/process-bundle v5.3 still requires it (cleverage/process-bundle#268 not released yet). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #149: clean up
composer.json(same cleanup as cleverage/process-bundle#268, part of the dependency check of process-bundle and all the bridges).Changes
src/,config/,templates/,tests/):symfony/dotenv,symfony/runtime(application concerns:.envloading,bin/console,public/index.php),ext-ctype,ext-iconv(Symfony skeleton leftovers).doctrine/common→doctrine/collections: the onlyDoctrine\Common\*class used isArrayCollection(DoctrineProcessHandler).doctrine/collections^1.5 || ^2.1 || ^3.1ArrayCollectiondoctrine/orm2.20 / 3.xdoctrine/migrations^3.2AbstractMigration(all migrations)doctrine/doctrine-migrations-bundle3.7doctrine/persistence^3.1 || ^4ManagerRegistrydoctrine/doctrine-bundle2.18psr/log^2 || ^3LoggerInterfacemonolog/monolog3symfony/event-dispatcher-contracts^3Symfony\Contracts\EventDispatchercleverage/process-bundlesymfony/twig-bundle^6.4 || ^7.4 || ^8twig.extensiontags,<twig:…>componentstwig/twig^3.23src/Twigextensionseasycorp/easyadmin-bundle5.0 (Twig 4 only exists as an alpha)require-dev:twig/extra-bundle^3.23(TestKernel),symfony/property-access^6.4 || ^7.4 || ^8(LogRecordTest).Differs from the issue:
symfony/runtimeis kept inconfig.allow-plugins. The released cleverage/process-bundle v5.3 still requiressymfony/runtime(cleverage/process-bundle#268 is merged but not released): without the entry,composer updatefails ("blocked by your allow-plugins config"). Development config only; it can be removed once a process-bundle release includes #268.Checks
composer validate --strict: OK.composer update:doctrine/commonno longer installed,symfony/dotenv/symfony/runtimeonly installed throughcleverage/process-bundlev5.3; 397 tests OK, PHPStan OK (no PHP / Twig change).composer update --prefer-lowest -Won the added packages (collections 2.2.0, migrations 3.9.5, persistence 4.0.0, psr/log 3.0.0, event-dispatcher-contracts 3.0.0, twig 3.27.0, extra-bundle 3.23.0, as allowed by the other requirements): 397 tests OK.Requirements
Breaking changes
None for the bundle API. Minor: once cleverage/process-bundle is released without them too, an application relying on the bundles to install
symfony/dotenv/symfony/runtimemust require them (the Symfony skeleton already does; the demo does since cleverage/process-bundle-demo#81).🤖 Generated with Claude Code