Repository navigation
#125 Small fixes: schedule context decoding, duplicated ROLE_USER, expression-language, naming strategy - #126
Merged
Merged
Conversation
…pression-language, naming strategy - ProcessSchedule::getContext(): json_decode() with true (a JSON object gave a stdClass) - User::getRoles(): ROLE_USER no longer duplicated when stored - symfony/expression-language declared (Assert\When), it was only a transitive dependency - docs: the entities expect the underscore_number_aware Doctrine naming strategy Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #125.
ProcessSchedule::getContext():json_decode($this->context, true)(a JSON object gave astdClass:TypeErroron the return type; not reached in practice, the column is a JSON column)User::getRoles():ROLE_USERno longer duplicated when it is stored (UserCreateCommandstores['ROLE_USER', 'ROLE_ADMIN'])composer.json:symfony/expression-languagedeclared (required byAssert\WhenonProcessSchedule::$expression, it was only a transitive dependency)docs/index.md: the entities expect theunderscore_number_awareDoctrine naming strategy (that of the Symfony recipe)Tests:
ProcessScheduleTest::testGetContextDecodesJsonString(JSON object),UserTest::testRoleUserIsNotDuplicated.Checked (Symfony 8.1, PHP 8.5): 284 tests OK; without the fix, both tests fail.
composer validate, PHPStan, PHP-CS-Fixer, Rector OK.Requirements
Breaking changes
None.
🤖 Generated with Claude Code