feat(registry) #25 Give the service ids in the error on duplicate adapter codes - #26
Merged
Merged
Conversation
…pter codes Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #25.
Two adapters with the same code made every cache process fail with
Adapter <code> is already defined, without telling which services are in conflict (they usually share the same class).RegisterAdaptersPass(new): registers the services taggedcleverage.cache.adapterinAdapterRegistrywith their service id, replaces the genericRegistryCompilerPassAdapterRegistry::addAdapter(): new optional$serviceIdargument; on a duplicate code, the message gives the ids of both services (unchanged message when an id is missing)AdapterRegistryTest,RegisterAdaptersPassTest(new)reference/adapter.md: update the note on unique codesChecked with process-bundle-demo, with a second
App\Adapter\MemoryAdapterservice taggedcleverage.cache.adapter:demo.cache.set_getnow fails withAdapter memory is already defined by service "app.cleverage_cache_process.adapter.memory", cannot register service "app.cleverage_cache_process.adapter.memory_duplicate"; without the duplicate, it still runs successfully.The CHANGELOG
Latestsection conflicts with #24: the one merged second needs a rebase.Requirements
Breaking changes
None: the new argument of
AdapterRegistry::addAdapter()is optional, only the exception message changes.🤖 Generated with Claude Code