chore(tests) #13 Add missing tests - #23
Merged
Merged
Conversation
… bundle and DI extension Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13.
Completes the tests added with #15 to #18 (which covered the fixed behaviours):
ZipTaskTest:filesas a single string, input overriding the configured options, existing archive overwritten, missing / unreadable file, directory given as a file, archive that cannot be opened, options validated on execution (not at initialization), undefined option in the input, invalid option typeUnzipTaskTest: input overriding the configured options, existing files overwritten and other files kept, missing / unreadable archive, options validated on execution, undefined option in the input, invalid option typeCleverAgeArchiveProcessExtensionTest(new): both tasks registered as non-shared services, with a public alias on their class (used as@<class>in process configurations)CleverAgeArchiveProcessBundleTest(new):getPath()is the bundle rootThe unreadable file tests are skipped when running as root.
Coverage: 79/80 lines. The only uncovered line is the
ZipArchive::addFile()failure inZipTask, not reachable once the file is checked to exist and be readable (addFile()only fails on close).Requirements
Breaking changes
None (tests only).
🤖 Generated with Claude Code