Repository navigation
Tag the test crash in Sentry - #98
Merged
Merged
Conversation
"Crash the app" now sets crash_type:forced on Sentry's scope before it crashes, the same tag the desktop Clementine gives crashes made with --crash, so test crashes can be filtered out of real ones. Sentry's SDK saves the scope with its crash report, so the tag reaches the event made from it on the next start. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R2bAq51UNk9WZ9L68KVQMA
ScreenshotsFrom run 44562481415, against a real Clementine. Left: main. Right: this pull request, light and dark.
Screens at a failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





































Requested by John · project thread
"Crash the app" in Settings (TestFlight and debug builds only) now sets
crash_type:forcedon Sentry's scope before callingSentrySDK.crash(). Desktop Clementine gives the same tag to crashes made with--crash, so test crashes can be filtered out of real ones the same way in both projects (!crash_type:forced). They still also differ by thetestflightenvironment.Unlike sentry-native's re-capture of minidumps on desktop, sentry-cocoa saves the scope with its crash report and applies it to the event it makes on the next start. So the tag is in the event that
beforeSendhands toCrashReportStore, and it's sent with it.No test: the tag can only be seen in the event made from a real crash, which unit tests can't do. Not built locally (no Xcode here), so CI is the build check.
Generated by Claude Code