Skip to content

Tag the test crash in Sentry - #98

Merged
hatstand merged 1 commit into
mainfrom
claude/project-thread-l573if
Nov 19, 2026
Merged

hatstand merged 1 commit into
mainfrom
claude/project-thread-l573if

Conversation

@hatstand

Copy link
Copy Markdown
Contributor

Requested by John · project thread

"Crash the app" in Settings (TestFlight and debug builds only) now sets crash_type:forced on Sentry's scope before calling SentrySDK.crash(). Desktop Clementine gives the same tag to crashes made with --crash, so test crashes can be filtered out of real ones the same way in both projects (!crash_type:forced). They still also differ by the testflight environment.

Unlike sentry-native's re-capture of minidumps on desktop, sentry-cocoa saves the scope with its crash report and applies it to the event it makes on the next start. So the tag is in the event that beforeSend hands to CrashReportStore, and it's sent with it.

No test: the tag can only be seen in the event made from a real crash, which unit tests can't do. Not built locally (no Xcode here), so CI is the build check.


Generated by Claude Code

"Crash the app" now sets crash_type:forced on Sentry's scope before it
crashes, the same tag the desktop Clementine gives crashes made with
--crash, so test crashes can be filtered out of real ones. Sentry's SDK
saves the scope with its crash report, so the tag reaches the event made
from it on the next start.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R2bAq51UNk9WZ9L68KVQMA
@hatstand hatstand self-assigned this Nov 19, 2026
@hatstand
hatstand enabled auto-merge (rebase) November 19, 2026 16:09
@hatstand
hatstand merged commit 2f0aded into main Nov 19, 2026
6 checks passed
@hatstand
hatstand deleted the claude/project-thread-l573if branch November 19, 2026 16:30
@github-actions

Copy link
Copy Markdown

Screenshots

From run 44562481415, against a real Clementine. Left: main. Right: this pull request, light and dark.

Screen main This PR This PR, dark
01_connect
02_queue
03_player
04_connection
05_settings
06_library
07_library_album
08_search
09_outputs
10_internet
11_internet_radio
fold_outer_player –

Screens at a failure

dark_failure

failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants