Repository navigation
Give the Apple Watch app the phone app's version and build number - #97
Merged
Merged
Conversation
TestFlight refused the first build with the watch app inside: its Info.plist had a fixed CFBundleVersion of 1, and App Store Connect wants a watch app's to be its phone app's (error 90379). It now takes MARKETING_VERSION and CURRENT_PROJECT_VERSION, as the app and the widget do, which scripts/archive.sh sets for each build. The archive's check now also compares the versions of the bundles inside the app, so a mismatch fails there rather than on upload. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R2bAq5cvLWgAnGu2dW6vr4
ScreenshotsFrom run 44420143790, against a real Clementine. Left: main. Right: this pull request, light and dark.
Screens at a failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





































Requested by John · project thread
Fixes the TestFlight upload after #46 (run 44418216393), which App Store Connect refused:
Changes
CFBundleShortVersionStringandCFBundleVersionfromMARKETING_VERSIONandCURRENT_PROJECT_VERSION, set inproject.ymlas the app and the widget do.scripts/archive.shalready sets both for each build.scripts/archive.sh's check of the exported .ipa also compares the version and build number of each bundle inside the app (the widget and the watch app) with the app's, so a mismatch fails the build rather than the upload.Independent of #94, which can merge before or after.
Testing
CI builds the app. The archive and its check only run on main, so the TestFlight run after this merges is the test.
Generated by Claude Code