Repository navigation
Every dependency on its current major (#288) - #116
Merged
Merged
Conversation
… typescript 7 typecheck
… TypeScript 7 typecheck (#292) (#113)
Member
Author
|
@greptileai review pls |
[Medium impact] The changes affect admin-dashboard builds and a few shared dashboard controls. The PR appears safe to merge, with one non-blocking correction to the JSX explanation. Findings
Fix with agent prompt### Issue 1
apps/admin/vitest.config.ts:20
The comment above says `tsconfig.json` uses `jsx: preserve`, but this PR changes it to `react-jsx`. Update the explanation so developers debugging JSX tests do not rely on an outdated reason for this override.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1) · Last reviewed commit: "Admin back bar keeps its blur in the Nex..." · Reviewed by Greptile |
| }, | ||
| // tsconfig keeps `jsx: preserve` for Next; tests need the automatic runtime. | ||
| esbuild: { jsx: "automatic" }, | ||
| oxc: { jsx: { runtime: "automatic" } }, |
There was a problem hiding this comment.
The comment above says tsconfig.json uses jsx: preserve, but this PR changes it to react-jsx. Update the explanation so developers debugging JSX tests do not rely on an outdated reason for this override.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/admin/vitest.config.ts
Line: 20
Comment:
**JSX explanation is outdated**
The comment above says `tsconfig.json` uses `jsx: preserve`, but this PR changes it to `react-jsx`. Update the explanation so developers debugging JSX tests do not rely on an outdated reason for this override.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves civfix/issue-tracker#288
Lands the epic's
integration/major-upgradeslane in this repo. Every change in it was a PR into the lane, merged there once green.Size: an epic's landing PR; its parts were reviewed as PRs into the lane.