Skip to content

Every dependency on its current major (#288) - #116

Merged
byteful merged 9 commits into
mainfrom
integration/major-upgrades
Nov 6, 2026
Merged

byteful merged 9 commits into
mainfrom
integration/major-upgrades

Conversation

@byteful

@byteful byteful commented Nov 5, 2026

Copy link
Copy Markdown
Member

Resolves civfix/issue-tracker#288

Lands the epic's integration/major-upgrades lane in this repo. Every change in it was a PR into the lane, merged there once green.

Size: an epic's landing PR; its parts were reviewed as PRs into the lane.

@byteful

byteful commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

@greptileai review pls

@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5 Tier: apex

[Medium impact] The changes affect admin-dashboard builds and a few shared dashboard controls.

The PR appears safe to merge, with one non-blocking correction to the JSX explanation.

Findings

  1. P2 JSX explanation is outdated ▶
Fix with agent prompt
### Issue 1
apps/admin/vitest.config.ts:20
The comment above says `tsconfig.json` uses `jsx: preserve`, but this PR changes it to `react-jsx`. Update the explanation so developers debugging JSX tests do not rely on an outdated reason for this override.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1) · Last reviewed commit: "Admin back bar keeps its blur in the Nex..." · Reviewed by Greptile

Comment thread apps/admin/vitest.config.ts Outdated
},
// tsconfig keeps `jsx: preserve` for Next; tests need the automatic runtime.
esbuild: { jsx: "automatic" },
oxc: { jsx: { runtime: "automatic" } },

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 JSX explanation is outdated

The comment above says tsconfig.json uses jsx: preserve, but this PR changes it to react-jsx. Update the explanation so developers debugging JSX tests do not rely on an outdated reason for this override.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/admin/vitest.config.ts
Line: 20

Comment:
**JSX explanation is outdated**

The comment above says `tsconfig.json` uses `jsx: preserve`, but this PR changes it to `react-jsx`. Update the explanation so developers debugging JSX tests do not rely on an outdated reason for this override.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@byteful
byteful added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 395e57d Nov 6, 2026
7 checks passed
@byteful
byteful deleted the integration/major-upgrades branch November 6, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants