Repository navigation
[chnobli] fix: scroll position at the end of the last trigger - #8
Merged
Merged
Conversation
calcPosition only matched y < endY, so at exactly the last offset (the bottom of the page, where y can't get past it) no window matched and it returned -1: the scroll went to "before" and its timelines jumped back to the start. The end is included now, a zero height window gives its end position. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At exactly the last trigger's offset (the bottom of the page, which the scroll can't get past)
calcPositionmatched no window and returned -1, so the scroll state went tobeforeand its timelines jumped back to the start. Seen on the chnobli.com port: at the bottom of the page the growing dot disappears instead of filling the screen.The last window now includes its end; a zero height window gives its end position. New test
src/tests/scroll.test.tsfails without the fix.properties > restore beforealready fails on master (the test for #7).🤖 Generated with Claude Code