Skip to content

[chnobli] fix: scroll position at the end of the last trigger - #8

Merged
noah-meierlabs merged 1 commit into
masterfrom
fix-scroll-end
Nov 4, 2026
Merged

noah-meierlabs merged 1 commit into
masterfrom
fix-scroll-end

Conversation

@noah-meierlabs

Copy link
Copy Markdown
Contributor

At exactly the last trigger's offset (the bottom of the page, which the scroll can't get past) calcPosition matched no window and returned -1, so the scroll state went to before and its timelines jumped back to the start. Seen on the chnobli.com port: at the bottom of the page the growing dot disappears instead of filling the screen.

The last window now includes its end; a zero height window gives its end position. New test src/tests/scroll.test.ts fails without the fix. properties > restore before already fails on master (the test for #7).

🤖 Generated with Claude Code

calcPosition only matched y < endY, so at exactly the last offset
(the bottom of the page, where y can't get past it) no window matched
and it returned -1: the scroll went to "before" and its timelines
jumped back to the start. The end is included now, a zero height window
gives its end position.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@noah-meierlabs
noah-meierlabs merged commit 33c7145 into master Nov 4, 2026
1 of 3 checks passed
@noah-meierlabs
noah-meierlabs deleted the fix-scroll-end branch November 4, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant