Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe runner image now installs Playwright Chromium runtime libraries. The package version changes from 0.17.5 to 0.17.6. ChangesContainer and Release
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The PR adds the declared Chromium runtime libraries and updates the package version consistently; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the change, motivation, package list, version bump, and verification steps. It does not use the required Summary, Type of Change, and Checklist sections or provide their required checkbox information.
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #357, which fixes the same problem differently: the Chromium runtime libraries are resolved by Playwright itself ( The Closing in favour of #357. |
What
Adds the 18 system libraries Playwright's Chromium (1.63) needs at runtime to the
runnerimage stage, so e2e is ready out of the box in every OCM deployment.Why
OpenCode agents run Playwright e2e suites (
bun run e2e) inside the container. Without root/sudo in the image, each fresh container needed a userspace bootstrap that downloads and extracts those .debs. Baking the libraries in makes the bootstrap a no-op on up-to-date images.Details
RUN apt-get install --no-install-recommendslayer in the runner stage (after the microsandbox install, before the ENV block), with apt lists cleaned.lddof the Playwright chromium headless shell on Debian trixie (the image base is Debian trixie):libasound2t64 libatk-bridge2.0-0t64 libatk1.0-0t64 libatspi2.0-0t64 libcups2t64 libdbus-1-3 libdrm2 libgbm1 libnspr4 libnss3 libxcomposite1 libxdamage1 libxfixes3 libxi6 libxkbcommon0 libxrandr2 libavahi-client3 libavahi-common3Verified
Note: the Chromium browser itself is intentionally not baked in (kept the image lean); a fresh container downloads it once via the repo's
e2e:setupscript.Summary by CodeRabbit
Improvements
Chores