Skip to content

Align addon CI guide with adopted local and complete CI gates - #269

Merged
shiny-code-app[bot] merged 5 commits into
mainfrom
work/q700-1023-addon-guide
Oct 23, 2026
Merged

shiny-code-app[bot] merged 5 commits into
mainfrom
work/q700-1023-addon-guide

Conversation

@shiny-code-app

@shiny-code-app shiny-code-app Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

The addon-CI guide still describes filtered legacy callers and an optional local selection root. Align it with adopted local/CI gates, defer variable/preparation rules to each caller's declarations, and preserve complete candidate testing through that caller's supported trigger policy. This keeps CM231's once-per-candidate batch-PR route. Remove the resolved shared40 browser-gap note.

One documentation file, 13 additions and 14 deletions. No runner, workflow, artifact input or product behavior changes. Diff/link checks pass. Anthropic Claude Opus 5.5 reviewed in two completed rounds; final bounded wording fixes are weighed separately. Repository CI remains required before ready. Inspection NOT RUN under the brief's explicit JetBrains prohibition.

Required final-head consumer builds passed on attempt1 for devkit d79a0ee624f600f5a467a03fefb6460420b1a1f5:

  • CM website40018715932: tenant source a9ad996228e6661a8a04e8644d163eed7b5652a9.
  • OPW40018719180: tenant source ab93f170af4ffe6f86e56163f6cb4ee70081ea7b. The workflow deliberately checks out current main; its documentation landing advanced main after the dispatch event. The artifact's actual source is verified on main's first-parent history.

Downloaded consumer-build-check-1 artifacts bind that exact devkit/source pair, linux/amd64 and dependency/base-image/addon provenance. OPW's initial job-list read returned404 after confirmed dispatch; exact-run readback and the supported watch recovered. No redispatch of that request, image publication, deployment, production/data change, grant, credential/license handling or Client contact.

Client test notes

Nothing for the Client to test: engineering documentation alignment only, with no product or runtime behavior change.

Refs cbusillo/codex-skills#1884 (Q700-1023).

@shiny-code-app

Copy link
Copy Markdown
Contributor Author

Review result: weighed
Head: d79a0ee

Anthropic Claude Opus 5.5 completed two review rounds. Fixed: distinguish adopted focused/full commands from the raw legacy declaration; defer exported variables and preparation to each caller instead of maintaining a drifting second list; link the shared test contract; preserve each caller's complete source/candidate coverage without requiring duplicate train-push execution. Removed the already-resolved shared40 note. The bounded final paragraph deletion fixes the whole duplicate-list cause, with no code or test change.

Both final-head consumer builds passed on attempt1: CM website40018715932 and OPW40018719180. Downloaded artifacts bind exact runtime d79a0ee, linux/amd64 and dependency provenance. CM website source is a9ad9962. OPW's actual checkout source ab93f170 is verified on current main's first-parent history; its existing ref:main checkout advanced beyond the dispatch-event b49f341 during the run. The initial event-head equality assertion in my private verification was therefore too strict; actual checkout/source binding, not the event's older main tip, is the owning contract. No product check was waived.

OPW's first job-list read returned404 after the dispatch had succeeded; the exact returned run was read back and watched successfully, without redispatch. No image publication/deployment, grant, credential/license handling, production/data action or Client contact. Inspection NOT RUN under the explicit brief prohibition. No new literal/config/workflow text test. No unresolved review defect remains; complete repository CI must still pass at this same head before ready.

@shiny-code-app

Copy link
Copy Markdown
Contributor Author

Ready for the merge train

Head: d79a0ee

@shiny-code-app

shiny-code-app Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor Author

Launchplane completed the merge-train step for this pull request.

Launchplane finished the merge-train step for this pull request.

Launchplane manages this comment and will update it as the train moves.

shiny-code-app Bot added a commit that referenced this pull request Oct 23, 2026
@shiny-code-app
shiny-code-app Bot merged commit 142ce23 into main Oct 23, 2026
5 checks passed
@shiny-code-app
shiny-code-app Bot deleted the work/q700-1023-addon-guide branch October 23, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants