Repository navigation
Keep equivalent PostgreSQL dump/restore schema fingerprints stable - #5184
2 commits merged into
Conversation
|
Review result: weighed Independent review: Anthropic Claude Opus 5.5, confirmed by the default review helper CLI receipt, reviewed committed head 09d1ad6. No source defect found. Acted on: the literal-array quote/spacing test pinned the chosen canonical spelling. Head 6c5f54b replaces that assertion with fingerprint equivalence while retaining idempotence and unsupported-form checks. All five focused fingerprint tests, Ruff and formatting passed. This is a local test-only correction; the reviewed source is unchanged. Informational findings: unsupported defaults/trigger expressions continue to refuse rather than hide differences; the reviewer found no current triggering schema. No speculative expansion added. Old receipts deliberately mismatch: a fresh native read confirms no commit-pending recovery proof in the actual maintenance state root, and the only actual first hold is released. The earlier plan-only directory never held writers. Q777 requires a new whole hold and backup after this deploy. The brief requires this operational documentation for review and the bounded hold, so the optional prose shortening was not needed to correct behavior. All 61 maintenance/host/PostgreSQL tests passed before the test-only change; the five affected tests passed afterward. Native PyCharm completed with only eight known Python 2.7 tool misclassifications under the recorded Director exception while cbusillo/codex-skills#2923 remains open. No unresolved reproduced defect. Removed: 5 replaced lines. Net lines: +333 including tests and operating documentation. |
|
Ready for the merge train Head: 6c5f54b |
…dd2f1aac46982d2: merge PR #5184
|
Launchplane completed the merge-train step for this pull request.
Launchplane landed this pull request through protected batch PR #5186. Launchplane manages this comment and will update it as the train moves. |
b6a5383
PostgreSQL reparses some varchar-to-text literal arrays during a full dump/restore. Identical retained rows and equivalent constraints therefore produced different schema fingerprints and correctly stopped the Q777 rehearsal. Normalize only the equivalent complete ANY/ALL literal-array operand forms, while keeping semantic changes and unsupported differences distinct. Scope deterministic deparsing settings to a savepoint that restores settings and releases successfully before the keeper exports its snapshot.
Refs #2437 and #5153. Source delivery only: no live schema/data changes. The operational finish line remains a NEW whole writer/deploy hold and NEW verified full backup, passing isolated restore/migration rehearsal, exact retirement and release/readback under Q777. The earlier diagnostic capture cannot authorize a later window.
Validation: all 61 maintenance/host/real PostgreSQL 18.6 tests passed, including actual deparsed-DDL round trips, meaningful schema changes, settings error recovery, blocked concurrent writes and snapshot export. Ruff, role words and mypy (1898 files) passed. Native PyCharm completed with eight known Python 2.7 misclassification findings under the recorded Director exception while cbusillo/codex-skills#2923 is open; actionable findings were fixed. Independent review by Anthropic Claude Opus 5.5 is complete and weighed on the current head. The identified canonical-spelling test pin was corrected and the five affected fingerprint tests passed again.
Removed: 5 replaced fingerprint/integration lines. Net lines: +333, including behavior tests and operating instructions.