Repository navigation
Launchplane batch: #4684 - #4693
Merged
Merged
Conversation
The installed read-only qualification (run 40097365197) exported format 2 and started the candidate, then rejected a scrubbed product profile: the scrubber had pseudonymized ProductSecretConfigRequirement.integration, which validators compare to runtime_environment. Code-protocol values now survive only in fields that declare them with the existing x-launchplane-snapshot-protocol marker: secret integration, the testing/prod lane kinds at every lane-instance reference site, and the defaults non-runtime profiles compare against. The same word in any other field is still pseudonymized. Database prefixes and public DNS names and addresses get format-valid pseudonyms only when the real validator accepts the source value, so invalid history still fails. Positional tuple schemas and all-digit hex digests are handled too. Refs #3413
Review: a valid 40-character hex-looking database prefix could become a digit-leading digest and fail, depending on the export salt. Format substitutes now run before the hex rule, which returns to its original order. Derive the oversized-prefix input from the schema, and state in the docs which invalid history still fails. Refs #3413
…35e7425981c7000: merge PR #4684
shiny-code-app
Bot
deleted the
launchplane/train/cbusillo/launchplane/main/merge-train-batch-cbusillo-launchplane-main-c35e7425981c7000
branch
October 24, 2026 15:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lands Launchplane's tested candidate
652a6bf035409f10579828c9a83340dddc386a9dthrough the protected merge endpoint. Constituent PRs and reviewed heads:77d4c325ecef6034b0cf54e215463c65dd7eeedeLaunchplane revalidates every constituent and records the shared landing effect. Keep source PRs and branches intact. Let the Launchplane controller merge this PR; do not merge it by hand or update its generated branch. An out-of-controller merge without a preceding admission remains fenced for explicit reconciliation. The controller confirms constituent completion after landing.
Owner test notes
#4684 Keep code-protocol values readable in scrubbed stored-record snapshots
#4684 has no Client test notes.