fix: use highest season number for season count - #47
Open
SpackledJim wants to merge 1 commit into
Open
SpackledJim wants to merge 1 commit into
SpackledJim wants to merge 1 commit into
Conversation
The show embed counted the entries in the seasons list, which gave the wrong number. It now shows the highest season number in that list. Seasons without a number count as 0, and an empty list shows 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show embed "Seasons" field shows the number of season records, not seasons
Commit:
02a3fbe—fix: use highest season number for season countCause
buildShowEmbedinsrc/lib/messages.tsusedtvdbSeries.seasons.length. TVDB can return several records per season (one per season type, e.g. official and DVD ordering), so the length can exceed the actual season count.Fix
numbercount as 0.0makes an empty list return 0 instead of-Infinity.