Post v145 fixes - #94
Merged
Merged
Conversation
filipppavlov
commented
Sep 17, 2026
filipppavlov
commented
Member
- convert the rest of CCP_STATS_ZONE macros
- move documentation to a project-specific directory
- convert the rest of CCP_STATS_ZONE macros - move documentation to a project-specific directory
There was a problem hiding this comment.
🟢 Approval recommended
The changes are focused, consistent with existing abstractions, and contain no identified correctness issues.
Pull request overview
Updates remaining statistics zones to the Trinity abstraction and places generated documentation under a project-specific installation directory.
Changes:
- Replaced remaining
CCP_STATS_ZONEcalls. - Changed documentation installation destination to
documentation/trinity.
File summaries
| File | Description |
|---|---|
trinity/Eve/SpaceObjectFactory/EveSOF.cpp |
Migrates two statistics zones. |
trinity/Eve/EveTriggerVolume.cpp |
Migrates two statistics zones. |
CMakeLists.txt |
Uses a project-specific documentation path. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ccptoebeans
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.