Repository navigation
feat(charms): complete the K8s charm class (13/14) - #367
Draft
marceloneppel wants to merge 2 commits into
Draft
marceloneppel wants to merge 2 commits into
marceloneppel wants to merge 2 commits into
Conversation
2 tasks
…-symlink target The K8S_*_LOGS_PATH literals already carry the 16/main prefix; inserting paths.versioned_path again produced /var/lib/pg/logs/16/main/16/main/pg_logs. Surfaced by the retained charm create-pgdata suite (charm 16/edge passes the full 16/main/pg_logs path as the ln target).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Part of the final charm->library migration: the K8s charm class stub becomes the faithful composition root. Final state: no logic charm-side.
Solution
PostgreSQLK8sCharm: the faithfulpostgresqlcached_property (Service endpoints + app secret), endpoint/replicas builders, TLS/ldap/primary/workload-running properties, the status bridges (refresh-priorityset_unit_status, gatedset_app_status,set_primary_status_message), the restart seams (request_restartscrape-job refresh + lock,restart_servicesmetrics/LDAP pebble restarts with the rotated-password check),update_config(per-relation map + async endpoints +DeployedWithoutTrustErrorblocking + the DPE-10203 standby_cluster clearing),_on_config_changed/_on_databases_change,fix_leader_annotation,on_deployed_without_trust, the pebble-layers replan guard,fix_pod, push/clean CA file, and the TLS reload bridge (trust-store sync then reload).K8sWorkload.generate_metrics_servicegained the DATA_SOURCE_* env (charm fidelity).tests/unit/test_k8s_charm.py(19 cases).Checklist
I have added or updated any relevant documentation.
I have cleaned any remaining cloud resources from my accounts.
Additional commit:
fix(workload)— the K8s log-symlink target dropped a duplicated16/mainsegment (K8S_*_LOGS_PATHliterals already carry the version prefix; the charm passes the full path as thelntarget). Pre-existing trunk bug surfaced by the retained charm create-pgdata suite.