Repository navigation
feat(charms): complete the VM charm class (7/7) - #361
Draft
marceloneppel wants to merge 1 commit into
Draft
marceloneppel wants to merge 1 commit into
marceloneppel wants to merge 1 commit into
Conversation
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The VM charm class must become concrete in the library so the charm-side file reduces to a thin subclass (final state: no logic charm-side).
Solution
PostgreSQLVMCharm: full composition bodies for every abstract seam — workload/substrate/postgresql/primary_endpoint properties, the refresh-aware status setters, theupdate_configwrapper (per-relation inputs + DPE-10203 stale-standby clearing), post-refresh side effects, exporter/ldap snap glue, CA push/clean, TLS reload/regenerate bridges,patroni_scrape_config, the disable-file guard, and the observer/rotate-logs init starts.utils/tracing.py: the sharedcharm_tracing_confighelper (ported verbatim; both charms call it).update_configsignature widened to the shared seam.tests/unit/test_vm_charm.py(status-setter priority, DPE-10203 clearing, primary/degraded/read-only/blocked-by-s3 messages).Checklist