Repository navigation
fix(react-native): stay inert without a native module instead of crashing - #262
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #261
What changed
A React Native build that leaves out Appduct's native module no longer crashes when the app registers a tool after startup; the API stays inert as intended.
NativeAppduct.tsnow looks the module up withTurboModuleRegistry.get, which returns null instead of throwing, so Metro'sguardedLoadModulehas nothing to report as fatal.resolveNativeModuleturns the null into the existing actionable error, outside Metro's guard, whereisAppductNativeModuleAvailablecatches it. Codegen 0.81.5 acceptsgetin a spec (@react-native/codegen/lib/parsers/utils.js:name === 'get' || name === 'getEnforcing').Acceptance criteria
registerToolafter startup does nothing and reports no fatal error under Metro's guarded requiremissing-native-module-metro.test.ts› registerTool stays inert without reporting a fatal errormissing-native-module-metro.test.ts› a direct native call still fails with the actionable errorE2E evidence
pending
Checklist
CHANGELOG.mdhas an entry underUnreleased(writing-changelogskill), or the change is not user-visiblewriting-user-docsskill), or the change is not user-visibleindex.ts; no new directnode:*I/O outside an adapterarchitectureskill applied, exceptions explained abovedocs/ARCHITECTURE.mdupdated if a surface it describes changedOut of scope
Running the device suite against a Release build without the native module (needs #247).
Status
Implement: done Review: pending E2E: pending Ready: yes