Skip to content

test(web): cover untagged and post-drop relay messages in the binding transport (#231) - #233

Merged
V3RON merged 3 commits into
mainfrom
issue-231-binding-stale-relay-message
Oct 14, 2026
Merged

V3RON merged 3 commits into
mainfrom
issue-231-binding-stale-relay-message

Conversation

@V3RON

@V3RON V3RON commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #257, which fixed #231.

What changed

#257 and this PR's first commits fixed the same stale-relay-message bug in parallel, so the fix itself is already on main. This PR now only adds what #257 left out:

  • A test that a relay message without an id reaches the active socket for message as well as open.
  • A test that the new socket still receives its own messages after the old socket's are dropped.
  • A doc-comment sentence saying where untagged messages come from: an older relay, or attachPage closing the page's socket.

No behaviour change.

Checklist

  • CHANGELOG.md: not user-visible, tests and a comment only
  • User-facing docs: not applicable
  • No new import past a module's index.ts; no new direct node:* I/O outside an adapter

@V3RON
V3RON marked this pull request as ready for review October 14, 2026 09:44
@V3RON V3RON changed the title fix(web): drop relay messages for a binding socket the page replaced test(web): cover untagged and post-drop relay messages in the binding transport (#231) Oct 14, 2026
@V3RON
V3RON merged commit 4f2cd1d into main Oct 14, 2026
10 checks passed
@V3RON
V3RON deleted the issue-231-binding-stale-relay-message branch October 14, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-attaching a page can fail with invalid_ack from a stale relay message

1 participant