fix(devin): catalog-driven model UIDs and tool-result images - #227
Merged
Merged
Conversation
…images Drop hardcoded swe-1-7/swe-1-6/glm-5-2 suffix tables that drifted from the upstream registry; suffixed UIDs are built from catalog thinking levels. Never pick "none" as an implicit default effort. Refresh the models fixture (64k completions, swe-1-7-lightning, glm-5-2 [none,max], image modalities). Tool results now carry images through to the Devin prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Track CLIProxyAPI's Devin registry update (v7.3.16 / commit
65459ca) and its tool-result image fix (v7.3.7):mapping.go: drop the hardcodedswe-1-7/swe-1-6/glm-5-2suffix tables. The upstream registry drifted —swe-1-7now only acceptsmedium(with a separateswe-1-7-lightningid),glm-5-2levels are[none, max], andswe-1-6has no thinking. Suffixedchat_model_uids are built purely from catalogthinking.levels, clamped per project rules.noneimplicitly — a[none, max]catalog defaults tomax;noneis only sent when explicitly requested.payload.go:toolrole messages go throughsplitContent, so images embedded in tool results reach the upstream prompt (prompt.Images) instead of being flattened away.max_completion_tokens64000,swe-1-7-lightning,glm-5-2 [none,max], image modalities onglm-5-3-flash/swe-1-6.Test plan
go test ./internal/providers/devin/...— new assertions coverglm-5-2(none/max),swe-1-7,swe-1-7-lightning, suffixed passthrough, and tool-result image passthroughgo test ./...— all greengit diff --checkclean