Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Responses requests whose upstream completion ends with
finish_reason: lengthare currently reported as completed and logged as successful. That loses the truncation signal for both API clients and operators.Behavior
finish_reason: lengthtostatus: incomplete.incomplete_details.reason: max_output_tokens.response.incompleteinstead ofresponse.completedfor streaming responses.incompletestatus.Tests
go test ./internal/gateway ./internal/accountsgo test ./internal/store -run '^TestSummarizeRequestLogs$' -count=1GOFLAGS=-buildvcs=false go test ./internal/app -run 'TestImportConstraints|TestDutyBoundaries' -count=1(cd frontend && npm run sync)(cd frontend && npm run lint)— 0 errors; 17 pre-existing warningsgit diff --checkEnvironment notes
The full
internal/storepackage run still hits existing Windows-only environment failures around SQLite temporary-file cleanup and Unix permission-bit expectations; the directly affected statistics test passes.