Repository navigation
Conversation
526ba77 made VirtualSetAttributes fail when the input carries owner IDs. Unfortunately that broke WinFSP as I accidentally made two WinFSP functions pass owner IDs without needing to: * Overwrite fetched the file's current attributes, so opening in some modes would fail if the file had owner IDs, like bb_worker sets. * SetSecurity always passed the owner and group, so every change to a file's DACL was rejected. I've added some integration tests to catch these in the future.
tomgr
marked this pull request as ready for review
October 8, 2026 15:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
526ba77 made VirtualSetAttributes fail when the input carries owner IDs. Unfortunately that broke WinFSP as I accidentally made two WinFSP functions pass owner IDs without needing to:
I've added some integration tests to catch these in the future. (I had Claude help write these.)