Repository navigation
feat(async): implement remaining core operation and collection stubs - #194
Closed
WilliamK112 wants to merge 0 commit into
Closed
WilliamK112 wants to merge 0 commit into
WilliamK112 wants to merge 0 commit into
Conversation
WilliamK112
changed the title
btoron
approved these changes
Oct 13, 2026
btoron
force-pushed
the
codex/async-core-operation-stubs-151
branch
from
October 18, 2026 13:56
e1a875c to
be654b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five async core methods reported in #151 now work instead of raising NotImplementedError. Activity search returns a typed list; move accepts a body-less 204 success; bulk update returns typed per-item errors/warnings and preserves explicit nulls while omitting unset fields. The two collection helpers gather typed activity/property pages, preserve filters and caller-owned field lists, advance offsets by actual returned counts, propagate later-page errors, and stop malformed empty-page/hasMore responses with a typed error. Default activity dates are evaluated at call time.
Closes #151.
README documents the contracts and collection memory behavior. The endpoint reference was regenerated, marking search/move/bulk update as available in both clients; the collection helpers reuse existing endpoints. Nullable date annotations are corrected.
Validation: 499 tests pass, 8 skip; all 52 new transport/paging cases failed before implementation. Cases cover filtered search, 204 moves, explicit-null/unset bulk data, partial bulk failures, typed HTTP/network errors, multi-page offsets, runtime defaults, invalid inputs, empty pages, and failures after partial collection. Ruff check/format, core-module Pyright (zero diagnostics), and diff checks pass. Contracts were checked against Oracle's search, move, and bulk update references. No live tenant operations were run.