Skip to content

Accept agy as a pre-launch reviewer kind (owner decision, D160 RC-1) - #6294

Merged
realmarcin merged 2 commits into
mainfrom
claude/agy-reviewer-kind-pr-20261119
Nov 19, 2026
Merged

realmarcin merged 2 commits into
mainfrom
claude/agy-reviewer-kind-pr-20261119

Conversation

@realmarcin

Copy link
Copy Markdown
Collaborator

Why

Owner decision D160 names Codex and agy as the two independent pre-launch reviewers (runbook Step 20). The v3 review-bundle validator, however, accepted only reviewer_kind 'claude' plus 'codex_cli' (native_launch_review.py:326-330). An agy review would have been refused at the review step, the capture word, the launch and read-final, and labelling a non-Claude review 'claude' would be false. agy found this in its Step 20 contract preparation (RC-1). The owner chose on 2026-11-19 to change the code to accept agy.

Change

  • native_launch_review.validate_bundle, current (v3) bundles:
    • accepts exactly codex_cli plus claude, or codex_cli plus agy, in either order;
    • refuses unknown kinds, duplicates, and any pair without codex_cli, including claude plus agy;
    • leaves every other check unchanged: two distinct reviewers, distinct from author and operator, independent approval, exact roles, time ordering, and immutable document bindings.
  • Historical v2 readback is unchanged: it still requires claude plus codex_cli.
  • Wire kind and version are unchanged.
  • Tests in tests/test_native_launch_review.py and tests/test_native_review_bundle_v3.py cover each accepted pair and each refusal.
  • D128 scanner approval refreshed at 1de1d0ff6: all 132 difference classes are identical to the baseline.

Pins: none moved. The pin chain check is clean, with no proposed edits and protected files intact.

Verification

  • Lead review of the diff: the pair rule is exactly the specification, and v2 behaviour cannot change. Without current, the only possible distinct pair is claude plus codex_cli.
  • Codex helper: focused and full-chain offline lanes. Their final results will be added as a comment.
  • Independent read-only review by agy: requested.

Follows PR #5968, which was fast-forwarded to 4b6f8a937. This PR is intended to merge the same way, so that main equals its head for the NP1.5 and launch bindings.

🤖 Generated with Claude Code

realmarcin and others added 2 commits November 18, 2026 20:55
All 132 difference classes are identical to the a1d7 baseline; hits
5292 -> 5308 as at the previous refresh.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@realmarcin
realmarcin merged commit e7721b6 into main Nov 19, 2026
95 checks passed
@realmarcin
realmarcin deleted the claude/agy-reviewer-kind-pr-20261119 branch November 19, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant