Conversation
masonsfc
marked this pull request as ready for review
September 23, 2026 17:52
masonsfc
force-pushed
the
mason/brev-configurable-firewalls
branch
3 times, most recently
from
September 23, 2026 22:18
6209604 to
7696880
Compare
masonsfc
force-pushed
the
mason/brev-configurable-firewalls
branch
from
September 27, 2026 04:41
7696880 to
6ee5c25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SFCompute V2 instances expose SSH through a proxy, so Brev cannot open application ports. This adds opt-in public IPv4 and configurable ingress. It requires the server lifecycle change in https://github.com/sfcompute/sfcompute/pull/11133, building on the merged networking endpoints in https://github.com/sfcompute/sfcompute/pull/11069.
enable_configurable_firewallto credentials, defaulting to false, and select public-IP-capable SKUs advertised by the pool.Deploy SFC #11133 before enabling the credential option. SFC firewall and instance creation commit separately; a process interruption between them can leave an unused firewall. Ordinary creation failures attempt cleanup, and failed termination cleanup can be retried.
Validation: provider tests with race detection,
go vet, golangci-lint, gofumpt, Codespell, andgit diff --checkpass. Coverage includes inline rules, default-off clients, unsupported servers, lifecycle cleanup and retry, rejected/unacknowledged creates, and concurrent rule edits. No live cloud instances were created.