Repository navigation
The runner line has no hosted default (rules-factory decision 0087) - #85
Merged
Merged
Conversation
A run whose variables name no runner now fails its job at once instead of going to a hosted runner. With this repository's variable set, every run goes where it went before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n 0087, after its review) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84
The
runs-online ended in a hosted default, so a run whose repository variables named no runner went to a GitHub-hosted runner without anyone choosing it. This takes rules-factory's corrected line (decision 0087, brandonifco/rules-factory#698).FACTORY_RUNS_ON_TRUSTED= factory-ci's labels (read on GitHub today), so every run goes where it went before."ubuntu-24.04", the job fails at once with a failed check ("Required runner group 'FACTORY_RUNS_ON or FACTORY_RUNS_ON_TRUSTED is unset or invalid' not found"), measured on GitHub, instead of running hosted..github/workflows/build-and-test.yml: theruns-online, and the comment above it../scripts/validate.sh full: every step passes exceptanalyzer-probe, which needs a .NET 8 SDK this machine does not have (9 and 10 are installed); CI installs one (build-and-test.yml).doc-referencespasses: the comment cites the decision asdecision, 0087, as the existing one cites 0080.factory-ci-1.🤖 Generated with Claude Code