Repository navigation
Run build-and-test on the runner-selection line of rules-factory decision 0080, with an exact .NET 8 version - #83
Merged
Conversation
…sion 0080 The owner's runs go to the factory-ci VM through the trusted dispatcher; forks and bots keep the GitHub-hosted ubuntu-24.04 by the line itself. The .NET 8 install becomes the exact 8.0.131 (same 8.0.31 runtime): the VM's read-only toolchain cannot follow a floating 8.0.x. Closes #82 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
build-and-testjob onto the runner-selection line of rules-factory decision 0080, so the owner's own runs go to the self-hostedfactory-ciVM through the trusted dispatcher. Forks and bots stay on GitHub-hostedubuntu-24.04by the line itself.FACTORY_RUNS_ON_TRUSTEDis already set on this repository; until this merges nothing changes..github/workflows/build-and-test.yml:runs-on: ubuntu-24.04becomes the 0080 line (copied byte for byte); the comment on the fixed release now says the hosted default is the fixed release and the owner's runs go to the factory-ci VM.setup-dotnet:8.0.xbecomes8.0.131. It carries the same 8.0.31 runtime the package probe needs, an exact version is reproducible, and the VM's read-only toolchain cannot follow a floating8.0.x(today it resolves to 8.0.425; the next patch would make the job try to install into a read-only directory).publish.yml(publishes to nuget.org, stays hosted) andpcg-vectors.yml(needs a C compiler the VM does not have; not a required check).Documentation
No repository document describes where CI runs, so none changes.
Verification
./scripts/validate.sh fulllocally: every step passes except step 8 (analyzer-probe), which fails because this machine has no .NET 8 SDK installed ("CI installs one (build-and-test.yml)"); that step is independent of this change and is what the8.0.131entry provides on CI.repo-checks(including action-pins and doc-references) and the tooling tests pass. The proof of the change is this pull request's ownbuild-and-testcheck, which should run on afactory-ci-1-jit-*runner.Closes #82
🤖 Generated with Claude Code